Repository navigation
[#2905] chore: replace labeler with the one that works like magpie and pull_r… - #2908
Conversation
|
@jbampton What do you think? |
|
@lprimak this is all new for me I'm not 100% sure. Is there a reference page or workflow ? |
|
Yes, this is GitHub's recommended split for privileged PR automation (avoiding pull_request_target ) • GitHub Security Lab: "Preventing pwn requests" – https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/ How it works: an unprivileged pull_request workflow only signals completion; a workflow_run workflow on the default branch (never checking out PR code) finds the PR from the head SHA and applies labels. The same approach is used by other ASF projects (e.g., what you called "magpie"). Note it can only be fully tested after merging, since workflow_run runs from the default branch. |
|
I have checked on another repo and this should work. |
…equest workflow
fixes #2905
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.